Improve accessibility #1977
Merged
Improve accessibility #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will make the sidebar collapse at smaller widths. To activate the sidebar, the user can hover their mouse over the collapsed sidebar or click the already existing toggle button.
This commit will add title links to the sidebar links in the dashboard so users can hover over the links and see what it says.
kirkkwang
force-pushed
the
improve-accessibility
branch
from
b6bdc2f
to
635753a
Compare
This commit will ensure that the custom alt text that is set in the Dashboard > Settings > Appearance > Default Images section will be used in the partials that display the images. Also a new help text was added to the collection dashboard page to more accurately describe the action.
This commit will run the i18n translate-missing task to update from en to all other supported languages.
This commit will update IIIF Print to use the updated representative_media partial which has the custom thumbnail and alt text.
kirkkwang
force-pushed
the
improve-accessibility
branch
from
635753a
to
dfb4dc8
Compare
ShanaLMoore
approved these changes
Aug 14, 2023
jeremyf
added a commit
to scientist-softserv/adventist_knapsack
that referenced
this pull request
Oct 10, 2023
The following commit added the ability to use the alt text for a default_collection_image_text. This improves accessibility while also removing an override file. samvera/hyku@f28ede5 Bellow is the *Diff of knapsack and Hyku file*. <details><summary>Diff of knapsack and Hyku file</summary> ``` ❯ diff app/views/hyrax/collections/_media_display.html.erb hyrax-webapp/app/views/hyrax/collections/_media_display.html.erb 4c4 < alt: "", --- > alt: block_for(name: 'default_collection_image_text'), 8c8 < <% end %> \ No newline at end of file --- > <% end %> ``` </details> Related to: - samvera/hyku#1977
jeremyf
added a commit
to scientist-softserv/adventist_knapsack
that referenced
this pull request
Oct 10, 2023
The following commit added the ability to use the alt text for a default_collection_image_text. This improves accessibility while also removing an override file. samvera/hyku@f28ede5 Bellow is the *Diff of knapsack and Hyku file*. <details><summary>Diff of knapsack and Hyku file</summary> ``` ❯ diff app/views/hyrax/collections/_media_display.html.erb hyrax-webapp/app/views/hyrax/collections/_media_display.html.erb 4c4 < alt: "", --- > alt: block_for(name: 'default_collection_image_text'), 8c8 < <% end %> \ No newline at end of file --- > <% end %> ``` </details> Related to: - samvera/hyku#1977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs scientist-softserv/utk-hyku#489
This PR will bring in accessibility changes from UTK which includes:
Relevant PR's