-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚧 i205 - add ability to upload collection thumbnails #2206
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShanaLMoore
changed the title
🚧 i205 - add ability to upload thumbnails
🚧 i205 - add ability to upload collection thumbnails
May 6, 2024
ShanaLMoore
commented
May 6, 2024
ShanaLMoore
force-pushed
the
i205-upload-collection-thumbnails
branch
from
May 6, 2024 23:11
af4df7c
to
609d333
Compare
This commit is implemented following the precendence set by collection branding's banner and logo uploads. TODO: - add and update specs - attach image to collection thumbnails - thumbnails should link to the associated collection
ShanaLMoore
force-pushed
the
i205-upload-collection-thumbnails
branch
from
May 6, 2024 23:16
609d333
to
750b4ce
Compare
This commit will make the collection thumbnails show up in the views such as in the dashboard list of collections and also in the catalog search results. The gitignore was updated to ignore the path where the thumbnails are stored.
houndci-bot
reviewed
May 7, 2024
kirkkwang
force-pushed
the
i205-upload-collection-thumbnails
branch
3 times, most recently
from
May 8, 2024 16:24
0113466
to
0c9a10b
Compare
houndci-bot
reviewed
May 8, 2024
This commit will fix a bug where if the user sets the thumbnail first and then later sets the alt text, they would have to have to remove the thumbnail and re-add it and set the alt text at the same time to get the alt text to be set.
kirkkwang
force-pushed
the
i205-upload-collection-thumbnails
branch
from
May 8, 2024 17:05
0c9a10b
to
56b5788
Compare
This commit will add a rake task to migrate the Hyku Commons collection thumbnails which uses the /uploads/uploaded_collection_thumbnails/ path as opposed to a downloads controller endpoint.
Moving back to draft to address spec failures. cc @kirkkwang Update: Specs were flaky. They passed after re running the pipeline. ✅ |
orangewolf
requested changes
May 10, 2024
lib/tasks/migrate_hyku_commons_collection_thumbnails_to_valkyrie.rake
Outdated
Show resolved
Hide resolved
lib/tasks/migrate_hyku_commons_collection_thumbnails_to_valkyrie.rake
Outdated
Show resolved
Hide resolved
This commit will address the code review comments with the following: - remove the /uploads gitignore, turns out there was a deeper issue with where collection branding files were being saved - remove a stray comment - remove an unnecessary TODO - remove an unnecessary method definition in the new rake task
orangewolf
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The ability for collections to have thumbnails will be deprecated in Hyrax v5.0.0.
This PR implements the ability to upload collection thumbnails by following the precedence set by the collection's branding's banner and logo uploads.
Ideally we'd contribute this back if the community supports it. However, for the sake of time we are overriding Hyrax instead.
TODO: