Skip to content

Commit

Permalink
Removing spec files from gem distribution…
Browse files Browse the repository at this point in the history
This time for real.

With SHA 42bf8a1 I removed the
test_files from gem distrubtion. However, the files would have
continued to be distributed. I discovered this when I went to try to
release Hyrax 2.7.0, and got the same error.

I wrote the Regular Expression to skip the spec directory. This leaves
me a bit non-plussed, as its more invasive and seems to break more of
the practices.

To test if this would work, I made the change and then ran:

```console
$ gem build hyrax.gemspec
```

That command built the gem file for distribution, and worked. My plan
is to push up a second commit to compare and contrast. I'm not happy
with what is needed, as the previous commit felt appropriate and this
feels more invasive. Perhaps I'm overly concerned and this is the best
means forward, especially considering our discussion.

This builds on PR #4239
  • Loading branch information
jeremyf committed Feb 2, 2020
1 parent 0888454 commit 95e8e44
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hyrax.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ SUMMARY

spec.homepage = "http://github.com/samvera/hyrax"

spec.files = `git ls-files`.split($OUTPUT_RECORD_SEPARATOR)
spec.files = `git ls-files`.split($OUTPUT_RECORD_SEPARATOR).select { |f| File.dirname(f) !~ %r{\A"?spec\/?} }
spec.executables = spec.files.grep(%r{^bin/}).map { |f| File.basename(f) }
spec.name = "hyrax"
spec.require_paths = ["lib"]
Expand Down

0 comments on commit 95e8e44

Please sign in to comment.