-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement IIIFv3 and Lambda response streaming #114
Conversation
1a9097d
to
0ecd498
Compare
a0db911
to
bfc172f
Compare
eea2fd0
to
76e12cd
Compare
98303bb
to
946d7e8
Compare
A preview of the changes to the documentation is available at: NextJS and S3 static site hosting don't work real well together, so you always have to enter through the index page. Deep linking and refreshing after navigation will break things. But the relevant sections for this PR can be found by navigating to:
|
Formatting updates to markdown content More style updates to homepage Add new diagram image and update SEO Add Solutions and Under the Hood sections to About page for ideas Clean up styling on About page. Add Step components to installation instructions Add documentation deployment workflow
37555bd
to
6002c0a
Compare
6002c0a
to
0f48da8
Compare
- Convert Lambda to streaming function url - Use IIIF v3 branch of node-iiif - Add IIIF v3 tests and other supports - Add service discovery endpoint at `/` - Create Terraform module - Create CloudFormation and Terraform examples - Enhance docs - Build CloudFormation & Terraform documentation dynamically - Refactor build/deploy/delete commands to use new YAML config - Update to NodeJS v18.x - Update to aws-sdk v3 Co-Authored-By: Rob Kaufman <rob@notch8.com>
0f48da8
to
118bf50
Compare
Replace default "" with JP2 Expose PyramidLimit parameter for efficient ptiff handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We completed compatibility testing and I think this is good to ship! Great work on this.
I'd love to see this released this week if possible to spin up a new application and meet an end-of-the-month deadline! ❤️ |
a59f4af
to
283b7b1
Compare
f550913
to
e01f7f6
Compare
e01f7f6
to
f30bcbf
Compare
|
f30bcbf
to
1c957d4
Compare
I've been following along very closely trying to plan a deployment when this is ready. Thank you for the example template for CloudFormation. This may be the wrong place to ask since you are in the middle of working on it, but it does relate to the new docs. In reading through and trying to understand, I'm not sure how to distinguish the |
Before I merge this, I have one more request. I decided, based on some developer conversations, that it would be best to keep the CloudFront wrapper in the next release, but with a deprecation notice and examples in the README (the one that displays in the Serverless App Repo, which will now be separate from the one in the project root). A second (or third, or fourth) set of eyes on these changes would be extremely helpful. The files that need vetting are:
Anywhere any of those point to directories within https://github.com/samvera/serverless-iiif/tree/main, the PR content is at https://github.com/samvera/serverless-iiif/tree/v5.0-streaming-iiif3. (I couldn’t make them relative links because they’re going to be published to the AWS App Repository. We also have a great new doc site created by @adamjarling. It’s already deployed off @orangewolf @t4k @tpendragon @edsilv @codeclout @fitnycdigitalinitiatives @theiawolfe |
If you take a look at these two lines in the CloudFormation template, you'll see the issue. Route53 wants both the FQDN of the record you're creating, as well as the name of the zone it's hosted in. For Obviously this is just an example template. You're free to ask for and use those pieces however you need you. You could ask for the full name ( |
I've read through the new documents and deprecation warnings and they make sense. My only concern as an end user would be what would happen to a CloudFront-enabled 5.0 version when the deprecated wrapper code is removed in 5.1 or whenever it is. That could certainly be documented more clearly in the release notes for that future version, but the upgrade path or its pitfalls are not obvious to me. (Also, thank you for the response above, @mbklein. I see what is happening now. I glossed over the Route53 part because I don't use that service and instead talk to campus IT about all my DNS needs.) |
I went over the latest readme changes and the combination of edits around build/deployment. I did my best to run an ignorant install and that worked well. Like @t4k I don't always have DNS control and both of our production sites would require met to talk to clients who then talk to campus IT, so I only testing DNS stuff against a sample domain. |
Implement IIIFv3 and Lambda response streaming
Implement IIIFv3 and Lambda response streaming
/