feat: add support for user-installable apps #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also transiently blocked by the following PRs which block going through the Sapphire release order: |
Signed-off-by: Seren_Modz 21 <seren@kings-world.net>
Signed-off-by: Seren_Modz 21 <seren@kings-world.net>
Signed-off-by: Seren_Modz 21 <seren@kings-world.net>
Signed-off-by: Seren_Modz 21 <seren@kings-world.net>
Signed-off-by: Seren_Modz 21 <seren@kings-world.net>
Signed-off-by: Seren_Modz 21 <seren@kings-world.net>
Signed-off-by: Seren_Modz 21 <seren@kings-world.net>
favna
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on the following:
What commands should I allow to be used from a user-install and which ones should I limit to guild-installs? Right now, I've only done the ping command.Update: After looking at the Discord docs, I realized that I don't need to state explicitly all the integration types and contexts due to the defaults. Therefore, the current implementation of the ping command is redundant. Since the ping command is the only interaction-based command, what should I do? Create another command to test providing
integrationTypesandcontextsfor a guild-install command, or should I do something else?