Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @forward in sass-parser #2435

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Support @forward in sass-parser #2435

merged 2 commits into from
Nov 14, 2024

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Nov 13, 2024

No description provided.

@nex3
Copy link
Contributor Author

nex3 commented Nov 14, 2024

Test failures are caused by bufbuild/buf#3469, but this should be good to review.

pkg/sass-parser/lib/src/sass-internal.ts Outdated Show resolved Hide resolved
});
});

// Can't JSON-serialize this until we implement Configuration.source.span
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a github issue we can link to here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really just part of the general task of implementing sass-parser.

@nex3 nex3 merged commit e400bdd into main Nov 14, 2024
39 checks passed
@nex3 nex3 deleted the forward branch November 14, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants