[39] - Añadir endpoint create users a main

sayechu · Jun 2, 2024 · c24ee1d · c24ee1d
1 parent df3eed1
commit c24ee1d
Show file tree

Hide file tree

Showing 4 changed files with 47 additions and 5 deletions.
diff --git a/app/Infrastructure/CreateUser/AnalyticsCreateUserController.php b/app/Infrastructure/CreateUser/AnalyticsCreateUserController.php
@@ -0,0 +1,42 @@
+<?php
+
+namespace App\Infrastructure\CreateUser;
+
+use App\Exceptions\ConflictException;
+use App\Exceptions\InternalServerErrorException;
+use App\Infrastructure\Controllers\Controller;
+use App\Services\CreateUserManager;
+use Illuminate\Http\Response;
+use Illuminate\Http\JsonResponse;
+use Illuminate\Http\Request;
+
+class AnalyticsCreateUserController extends Controller
+{
+    private CreateUserManager $createUserManager;
+
+    public function __construct(CreateUserManager $createUserManager)
+    {
+        $this->createUserManager = $createUserManager;
+    }
+    public function __invoke(Request $request): JsonResponse
+    {
+        $username = $request->input('username');
+        $password = $request->input('password');
+
+        if (empty($username) || empty($password)) {
+            return response()->json(
+                ['error' => 'Los parámetros (username y password) no fueron proporcionados.'],
+                Response::HTTP_BAD_REQUEST
+            );
+        }
+
+        try {
+            $createUserMessage = $this->createUserManager->getCreateUserMessage($username, $password);
+            return response()->json($createUserMessage, Response::HTTP_CREATED);
+        } catch (ConflictException $e) {
+            return response()->json(['error' => $e->getMessage()], Response::HTTP_CONFLICT);
+        } catch (InternalServerErrorException $e) {
+            return response()->json(['error' => $e->getMessage()], Response::HTTP_INTERNAL_SERVER_ERROR);
+        }
+    }
+}
diff --git a/app/Services/CreateUserManager.php b/app/Services/CreateUserManager.php
@@ -8,6 +8,8 @@
 class CreateUserManager
 {
     private DBClient $dbClient;
+    private const CREATE_USER_MESSAGE = 'Usuario creado correctamente';
+    private const CONFLICT_ERROR_MESSAGE = 'El nombre de usuario ya está en uso.';
 
     public function __construct(DBClient $dbClient)
     {
@@ -23,14 +25,14 @@ public function getCreateUserMessage($username, $password): array
         $userExists = $this->dbClient->checkIfUsernameExists($username);
 
         if ($userExists) {
-            throw new ConflictException("El nombre de usuario ya está en uso.");
+            throw new ConflictException(self::CONFLICT_ERROR_MESSAGE);
         }
 
         $this->dbClient->createUser($username, $password);
 
         return [
             "username" => $username,
-            "message" => "Usuario creado correctamente"
+            "message" => self::CREATE_USER_MESSAGE
         ];
     }
 }
diff --git a/routes/web.php b/routes/web.php
@@ -18,4 +18,4 @@
 Route::post('/analytics/follow', AnalyticsFollowStreamerController::class);
 Route::get('/analytics/follow', AnalyticsFollowStreamerController::class);
 Route::delete('/analytics/unfollow', AnalyticsUnfollowController::class);
-Route::get('/analytics/users', AnalyticsCreateUserController::class);
+Route::post('/analytics/users', AnalyticsCreateUserController::class);
diff --git a/tests/Unit/Services/CreateUserManagerTest.php b/tests/Unit/Services/CreateUserManagerTest.php
@@ -18,8 +18,6 @@ class CreateUserManagerTest extends TestCase
     private const INTERNAL_SERVER_ERROR_MESSAGE = 'Error del servidor al crear el usuario.';
     private const CONFLICT_ERROR_MESSAGE = 'El nombre de usuario ya está en uso.';
     private const CREATE_USER_MESSAGE = 'Usuario creado correctamente';
-    private const BAD_REQUEST_ERROR_MESSAGE = 'Los parámetros (' . self::USERNAME . ' y ' . self::PASSWORD .
-                                               ') no fueron proporcionados.';
 
     protected function setUp(): void
     {