Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npy: first stab at a n-dim array with support for ragged-arrays #22

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

sbinet
Copy link
Owner

@sbinet sbinet commented Nov 24, 2023

Fixes #20.

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2023

Codecov Report

Attention: 270 lines in your changes are missing coverage. Please review.

Comparison is base (b2755b4) 57.86% compared to head (aa17140) 60.99%.
Report is 3 commits behind head on main.

❗ Current head aa17140 differs from pull request most recent head 7797a3e. Consider uploading reports for the commit 7797a3e to get more accurate results

Files Patch % Lines
npy/descr.go 63.80% 132 Missing and 28 partials ⚠️
npy/reader.go 36.36% 9 Missing and 33 partials ⚠️
npy/array.go 77.85% 26 Missing and 5 partials ⚠️
npy/pickle.go 73.33% 12 Missing and 4 partials ⚠️
npy/float16/float16.go 72.97% 10 Missing ⚠️
npy/npy.go 47.05% 9 Missing ⚠️
dump.go 60.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   57.86%   60.99%   +3.13%     
==========================================
  Files           8       12       +4     
  Lines        1571     2297     +726     
==========================================
+ Hits          909     1401     +492     
- Misses        513      707     +194     
- Partials      149      189      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fixes #20.

Signed-off-by: Sebastien Binet <binet@cern.ch>
Signed-off-by: Sebastien Binet <binet@cern.ch>
Signed-off-by: Sebastien Binet <binet@cern.ch>
Signed-off-by: Sebastien Binet <binet@cern.ch>
Signed-off-by: Sebastien Binet <binet@cern.ch>
@sbinet sbinet merged commit 7797a3e into main Dec 5, 2023
4 checks passed
@sbinet sbinet deleted the ragged-arrays branch December 5, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how to load npy file with dtype=object?
2 participants