Skip to content

Commit

Permalink
fixup
Browse files Browse the repository at this point in the history
  • Loading branch information
benzekrimaha committed Nov 28, 2024
1 parent ba7ade2 commit 71dec56
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
3 changes: 2 additions & 1 deletion lib/s3routes/routesUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ export const XMLResponseBackend = {
} else {
error = errors.InternalError.customizeDescription(errCode.message);
}
const description = error.description;
// early return to avoid extra headers and XML data
if (error.code === 304) {
response.writeHead(error.code);
Expand All @@ -148,7 +149,7 @@ export const XMLResponseBackend = {
'<?xml version="1.0" encoding="UTF-8"?>',
'<Error>',
`<Code>${errCode.message}</Code>`,
`<Message>${errCode.description}</Message>`,
`<Message>${description}</Message>`,
);
const invalidArguments = error.metadata.get('invalidArguments') || [];
invalidArguments.forEach((invalidArgument, index) => {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"sproxydclient": "github:scality/sproxydclient#8.1.0",
"utf8": "^3.0.0",
"uuid": "^10.0.0",
"werelogs": "scality/werelogs#8.2.0",
"werelogs": "github:scality/werelogs#8.2.2",
"xml2js": "^0.6.2"
},
"optionalDependencies": {
Expand Down
7 changes: 7 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7628,6 +7628,13 @@ webidl-conversions@^7.0.0:
fast-safe-stringify "^2.1.1"
safe-json-stringify "^1.2.0"

"werelogs@github:scality/werelogs#8.2.2":
version "8.2.2"
resolved "https://codeload.github.com/scality/werelogs/tar.gz/e53bef5145697bf8af940dcbe59408988d64854f"
dependencies:
fast-safe-stringify "^2.1.1"
safe-json-stringify "^1.2.0"

werelogs@scality/werelogs#8.2.0:
version "8.2.0"
resolved "https://codeload.github.com/scality/werelogs/tar.gz/7bf334cea94002d118f27d7ec1c7a5af74b51b8d"
Expand Down

0 comments on commit 71dec56

Please sign in to comment.