Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure needQuota flag is passed in stringified request context #2274

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

williamlardier
Copy link
Contributor

@williamlardier williamlardier commented Dec 7, 2024

We were relying on the default value from the constructor, but for special API calls, the flag may be needed when the default value is false.

Issue: ARSN-450

We were relying on the default value from the constructor, but
for special API calls, the flag may be needed when the default
value is false.

Issue: ARSN-450
@bert-e
Copy link
Contributor

bert-e commented Dec 7, 2024

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@williamlardier
Copy link
Contributor Author

williamlardier commented Dec 7, 2024

/approve

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.28%. Comparing base (7402f09) to head (5a6069f).
Report is 2 commits behind head on development/8.1.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           development/8.1    #2274      +/-   ##
===================================================
+ Coverage            66.27%   66.28%   +0.01%     
===================================================
  Files                  215      215              
  Lines                17329    17329              
  Branches              3529     3529              
===================================================
+ Hits                 11485    11487       +2     
+ Misses                5829     5827       -2     
  Partials                15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -256,7 +257,7 @@ export default class RequestContext {
this._securityToken = securityToken;
this._policyArn = policyArn;
this._action = action;
this._needQuota = actionNeedQuotaCheck[apiMethod] === true
this._needQuota = needQuota || actionNeedQuotaCheck[apiMethod] === true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not for this PR)
In the cleanup to come, I'm thinking we should probably make this class dumber and leave the decision up to cloudserver

@scality scality deleted a comment from bert-e Dec 7, 2024
@bert-e
Copy link
Contributor

bert-e commented Dec 7, 2024

Integration data created

I have created the integration data for the additional destination branches.

  • this pull request will merge bugfix/ARSN-450 into
    development/8.1
  • w/8.2/bugfix/ARSN-450 will be merged into development/8.2

The following branches will NOT be impacted:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Dec 7, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

  • ✔️ development/8.2

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70

Please check the status of the associated issue ARSN-450.

Goodbye williamlardier.

The following options are set: approve

@bert-e bert-e merged commit 5a6069f into development/8.1 Dec 7, 2024
7 checks passed
@bert-e bert-e deleted the bugfix/ARSN-450 branch December 7, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants