-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure needQuota flag is passed in stringified request context #2274
Conversation
Hello williamlardier,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
/approve |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development/8.1 #2274 +/- ##
===================================================
+ Coverage 66.27% 66.28% +0.01%
===================================================
Files 215 215
Lines 17329 17329
Branches 3529 3529
===================================================
+ Hits 11485 11487 +2
+ Misses 5829 5827 -2
Partials 15 15 ☔ View full report in Codecov by Sentry. |
@@ -256,7 +257,7 @@ export default class RequestContext { | |||
this._securityToken = securityToken; | |||
this._policyArn = policyArn; | |||
this._action = action; | |||
this._needQuota = actionNeedQuotaCheck[apiMethod] === true | |||
this._needQuota = needQuota || actionNeedQuotaCheck[apiMethod] === true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Not for this PR)
In the cleanup to come, I'm thinking we should probably make this class dumber and leave the decision up to cloudserver
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option
The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARSN-450. Goodbye williamlardier. The following options are set: approve |
We were relying on the default value from the constructor, but for special API calls, the flag may be needed when the default value is false.
Issue: ARSN-450