Standard authorization for backbeat routes #5714
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today, authorization results are not used. It is because before having implicit denies, we would have an AccessDenied directly. To be consistent, we must pass the authorization results. We thus allow the bucket policies and ACLs to be processed. Unit tests are added to cover all existing routes. Routes themselves are not direectly tested, only the router logic. We must first add tests for backbeat routes before merging more logic with the normal router. Issue: CLDSRV-591
Hello williamlardier,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
williamlardier
force-pushed
the
bugfix/CLDSRV-591
branch
from
f2523ac to
8200a2e
Compare
williamlardier
changed the title
williamlardier
force-pushed
the
bugfix/CLDSRV-591
branch
from
8200a2e to
86b0544
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
williamlardier
force-pushed
the
bugfix/CLDSRV-591
branch
3 times, most recently
from
c3b007f to
fa4422a
Compare
- Also split backbeat routers - Better use the callback functions - Do not return twice to the client in case of error and quota evaluation (finalizer hooks) - Remove account quota from backbeat proxy route: as not used in this case. Issue: CLDSRV-591
williamlardier
force-pushed
the
bugfix/CLDSRV-591
branch
from
fa4422a to
decfc8f
Compare
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
- Update old ones - Fix some tests not compatible with existing code, after confirming the changes were expected - Do not run the tests with azure/aws real backend in some cases, because the backends are either not healthy, or the tests doesn't work. To be done separately. Issue: CLDSRV-591
- To be re-enabled if we want to keep these tests - We also have a LocationNotFound error from AWS client, although properly configured in the location config file... Issue: CLDSRV-591
williamlardier
force-pushed
the
bugfix/CLDSRV-591
branch
from
ccd6116 to
a21ea94
Compare
- The bucket cleaning might not work during js tests, and can be expected - In such case, the java test should not enforce strict number of bucket, but use the existing number when starting... Issue: CLDSRV-591
williamlardier
force-pushed
the
bugfix/CLDSRV-591
branch
from
967ffc1 to
20412bc
Compare
- Same as java test, the scenario should never assume what the environment is, when the resources are shared. Issue: CLDSRV-591
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better review commit per commit
The goal here is to handle the authorization from the IAM module in the backbeat routes, and not rely on implicit deny === access denied, as this is not true anymore.
By doing so, we centralize the logic with all S3 APIs, and introduce some unit test to complete the functional tests from
tests/multipleBackend/routes/routeBackbeat.jsCurrent state: functional tests for the ceph test suite and the ones using a real azure/aws/gcp are still not running because they were disabled long time ago, and the resources are not existing anymore, some are still there, but it will be done in a separate ticket.