Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ts types #172

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Fix ts types #172

merged 3 commits into from
Nov 22, 2024

Conversation

williamlardier
Copy link
Contributor

Also backport the changes that were only targeting dev/8.2.

benzekrimaha and others added 3 commits November 22, 2024 09:04
@benzekrimaha @williamlardier
Fixup requestLogger end method
cfe44f1 
This commit aims to enable returning endLogger
instead of void, thus making it possible to make calls
to the endLoggerMehod for the requestLogger end method.
Issue : WRLGS-13
@williamlardier
Fix missing addDefaultFields methods in EndLogger types
f5bf410 
Issue: WRLGS-15
@williamlardier
Bump to v8.1.7
ede35ff 
Issue: WRLGS-15
@bert-e
Copy link
Contributor

bert-e commented Nov 22, 2024

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Nov 22, 2024

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@williamlardier
Copy link
Contributor Author

/create_integration_branches

@scality scality deleted a comment from bert-e Nov 22, 2024
@bert-e
Copy link
Contributor

bert-e commented Nov 22, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

francoisferrand
francoisferrand reviewed Nov 22, 2024
View reviewed changes
index.d.ts
@@ -21,6 +21,18 @@ interface LogDictionary {
}

declare module 'werelogs' {

class EndLogger {
Copy link
Contributor

@francoisferrand francoisferrand Nov 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it not be exported as well?

Copy link
Contributor Author

@williamlardier williamlardier Nov 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not using it directly, it's returned by the end() method from the request logger instances, so we do not need to export it.

@williamlardier
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Nov 22, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

  • ✔️ development/8.2

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/8.0

Please check the status of the associated issue WRLGS-15.

Goodbye williamlardier.

The following options are set: approve, create_integration_branches

@bert-e bert-e merged commit ede35ff into development/8.1 Nov 22, 2024
1 check passed
@bert-e bert-e deleted the improvement/WRLGS-15 branch November 22, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KillianG KillianG KillianG approved these changes

@francoisferrand francoisferrand francoisferrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@williamlardier @bert-e @francoisferrand @KillianG @benzekrimaha