Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ThrottlingListener to allow MFA attempt throttling #211

Closed
wants to merge 1 commit into from

Conversation

tostiheld
Copy link

@tostiheld tostiheld commented Dec 9, 2023

Trying again after I forgot about #165 😄

Still in draft, because I'm still working on tests, but I thought I would already put something up because of #SymfonyHackday

This basically does the same thing as the previous PR, with one notable improvement. I agree with the point that @hdk-pd made previously (#165 (comment)). Therefore I took some inspiration from symfony/symfony#38308 and implemented a combined ratelimiter instead of a single one. It will now ratelimit on both IP and user identifier.

@scheb
Copy link
Owner

scheb commented Dec 9, 2023

Thanks for the effort. We recently figured in #208 that the login_throttling feature on the firewall-level adds this behavior out-of-the-box, not only for the initial login, but also for the 2fa.

@tostiheld
Copy link
Author

Okay, I will close this.

@tostiheld tostiheld closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants