Remove autoplay value, fixing compatibility with Safari macOS and iOS 11 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autoplay is a boolean attribute, and Safari (both macOS and iOS 11 Safari) appears to choke if it is given a value. [The spec states](https://developer.mozilla.org/en-US/docs/Web/API/Element/setAttr ibute#Example), counter-intuitively, that passing an _empty string_ as the `value` is the proper way to to define a boolean attribute as `true`: > Boolean attributes are considered to be true if they're present on the element at all, regardless of their actual value; as a rule, you should specify the empty string (`””`) in `value` (some people use the attribute's name; this works but is non-standard).
Upon further testing it appears Safari iOS continues to choke even with an empty attribute. Considering the attribute should be applied to the HTML element itself, there shouldn't be a need to add it programmatically.
|
Upon further testing it appears iOS 11 Safari continues to choke on the blank attribute, so I have removed it entirely. |
|
Hello! When your pull request will be in release? I want using component in IOS 11! |
|
Have you teste it and it works? |
|
It's working for me on iOS 11 Safari. |
|
Any progress on this? Thanks! |
|
Hello, @thegreatsunra Could you propose this PR to my fork, please? |
thegreatsunra
added a commit
to thegreatsunra/instascan
that referenced
this pull request
Jun 26, 2018
|
Btw if your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autoplay is a boolean attribute, and Safari (both macOS and iOS 11 Safari) appears to choke if it is given a value.
The spec states, counter-intuitively, that passing an empty string as the
valueis the proper way to to define a boolean attribute astrue: