Hide user collection tag #794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndled to catch the override before running migrations
Base Containter Note and Bundle Before Migrations
support overriding gems via knapsack
📚 Doc two different methods for getting started
This involves adding a utility function `bin/knapsacker` Also reconciled the license in regards to Samvera licenses and copyright holders.
📚 Incorporate docs from Adventist knapsack
This commit documents the need for Knapsack to reference a branch; as well as provides documentation for doing so.
🧹 Configure Knapsack to Use Hyku Prime
references hyrax-webapp[tags/v5.2.0]. Required to get the build/pipeline working.
Get the build working
commit: samvera-labs/hyku_knapsack@5a7c54c which wasn't intentional bumped rails to 7+
This reverts commit 0363299.
This reverts commit 5a7c54c.
get fixes from adventist
This is a quality of life improvement. Use this generator to create a new work type in the Knapsack because using the Hyrax work generator will create files in the submodule and we don't want that. ```sh rails generate hyku_knapsack:work WorkType ```
This decorator needs to be in play for the work types to load their respective yaml files.
🎁 Add works generator
🎁 Add SimpleSchemaLoaderDecorator for work types
This commit will fix a bug where the controller template was not being found as well as the model spec. The path was corrected to match the path found in Hyrax. Lastly, the generator now includes adding Hyku specific includes to the controller and model files that were generated.
Update `HykuKnapsack::WorkResourceGenerator`
Update submodule to pull in thumbnail rendering fix + set HYKU_FILE_ACL to 'true' to fix permission issues seen in staging Issue: - #763
Update submodule to pull in thumbnail rendering fix + set HYKU_FILE_ACL to 'true' to fix permission issues seen in staging Issue: - #763 # Screenshots / Video ## BEFORE <img width="1169" alt="Screenshot 2024-08-20 at 3 11 07 PM" src="https://github.com/user-attachments/assets/402953fa-3a92-45f0-a639-dbcbc34c86ba"> ## AFTER <img width="1171" alt="Screenshot 2024-08-20 at 3 11 49 PM" src="https://github.com/user-attachments/assets/b49dfb7f-dd1f-48d0-8718-9e418197886e">
This commit fixes the linting issues on the Adventist Valkyrie project. The files in this commit have been modified by either rubocop auto fixes or manual disable and enable notations. There should not be any changes to the functionality of the application. Ref: - #741
This commit fixes the linting issues on the Adventist Valkyrie project. The files in this commit contain only whitespace changes or changing Note comments to NOTE as suggested by Rubocop. There should not be any changes to the functionality of the application. Ref: - #741
This commit excludes the hash alignment cop from the decorator file. There was a previous pattern established concerning hash alignments that conflicted with Rubocop's standards. We will be staying with the established pattern in the application. Ref: - #741
This commit updates depricated Rubocop syntax. `IgnoredMethods` for `Metrics/BlockLength` in the file `rubocop.yml` is replaced with `AllowedMethods`. `Metrics/LineLength` is replaced with `Layout/LineLength` in all appropriate files. Ref: - #741
There seems to be a bigger issue going on where some fields are getting `['']` as a value. This is a quick fix to prevent the view from bugging out when it encounters this.
Not sure how these got in here but we don't need these in the Knapsack so I'm removing them for now.
This commit fixes the failing application_spec and ignores the splash page spec that is currently failing due to the changes in styling. The client requested the styling be reverted to base Hyku. We are waiting to get feedback from the client on the styling of the splash page. If the page stays as is, this spec can be removed. If the styling is updated, this spec will need to be updated. Ref: - [741](#741)
Originally we had a require 'frigg' in this initializer because we want frigg to log and then load the slug logic. However, this threw off the load order of things and caused the Hyrax::PcdmCollection to be registered for Collection instead of CollectionResource. Wrapping this in a to_prepare will ensure it's loaded at the right time and keep it loaded in dev.
# Story This commit fixes the failing tests in the CI pipeline. Refs - [ ] #741 # Expected Behavior Before Changes Testing pipeline had two failing tests. # Expected Behavior After Changes There are no failing tests in the pipeline. # Screenshots / Video
# Story Refs #770 # Expected Behavior Before Changes Bulkrax imports were failing. # Expected Behavior After Changes Bulkrax imports successfully. # Screenshots / Video <details> <summary></summary> </details> # Notes
We had custom code for PDF.js to work with Adventist but it wasn't being honored because Hyku has a helper by the same name, so the Adventist one wasn't getting hit. Issue: - #731
GenericWork and Image resource models come from Hyku. They need to use custom configuration.
# Story Refs - #774 # Expected Behavior Before Changes PDF files did not split for Image & GenericWork resources. # Expected Behavior After Changes PDF files split into pages of the same model as the parent. # Screenshots / Video <details> <summary></summary>  </details> # Notes
Brings in bulkrax update.
# Story Refs - #770 # Expected Behavior Before Changes Reingesting a work failed due to expecting remote files. # Expected Behavior After Changes Able to reingest a work. # Screenshots / Video <details> <summary></summary> </details> # Notes
Provides a way to turn off pdf splitting for a tenant.
Doing it in the splitter meant the job errored instead of just not splitting.
# Story Refs - #779 # Expected Behavior Before Changes If the original file has a .pdf suffix, IiifPrint split will be attempted. # Expected Behavior After Changes PDFjs/UV feature flipper `use_iiif_print` will bypass splitting when set to PDFjs. # Screenshots / Video <details> <summary></summary> </details> # Notes Adding the flag to the splitter allowed the jobs to run and fail because no images were split. Instead the flag was moved to the beginning of the job itself, allowing the process to stop before submitting any further jobs.
Serverless Iiif does not support valkyrie. Issue: - #786
This commit hides the User Collection and Public tags from the public collection show pages (admin dashbaord) and the catalog search results page. Ref: - #791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
🎁 Hide User Collection and Public tags
This commit hides the User Collection and Public tags from the public
collection show pages (admin dashbaord) and the catalog search results
page.
Ref:
Expected Behavior Before Changes
User CollectionandPublictags were visible on the collection show pageUser CollectionandPublictags were visible on the catalog search resultsExpected Behavior After Changes
User collectionandPublictags are not visible on the collection show pageUser CollectionandPublictags are not visible on the catalog search resultsNotes
The acceptance criteria was updated to include the
Publictags as well as theUser Collectiontags. Approved by Katharine in Slack.