Update Hyku to bring in snippets fixes #860
Merged
+3
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusts snippets logic to match what is now in Hyku
ShanaLMoore
reviewed
Oct 26, 2024
ShanaLMoore
reviewed
Oct 26, 2024
We now use the logic from hyku without overriding it, so this spec is being removed.
ShanaLMoore
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Refs
Expected Behavior Before Changes
Snippets didn't work correctly
Expected Behavior After Changes
Screenshots / Video
Search on catalog page picks up terms in both full text and other metadata
clicking on work automatically searches the UV
Notes