Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is public basic #568

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Is public basic #568

merged 4 commits into from
Oct 31, 2024

Conversation

cziaarm
Copy link
Collaborator

@cziaarm cziaarm commented Oct 15, 2024

Story

Refs #issuenumber

Expected Behavior Before Changes

Expected Behavior After Changes

Screenshots / Video

Notes

Copy link

gitguardian bot commented Oct 15, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14078782 Triggered Generic Password 7773d2d ops/staging-deploy.tmpl.yaml View secret
14078782 Triggered Generic Password 8f66080 ops/staging-deploy.tmpl.yaml View secret
14078782 Triggered Generic Password 01611d7 ops/production-deploy.tmpl.yaml View secret
14158984 Triggered SMTP credentials 5d17506 ops/production-deploy.tmpl.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@cziaarm cziaarm merged commit 888c6d7 into main Oct 31, 2024
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant