Knapsack pals #15
Merged
Knapsack pals #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a quality of life improvement. Use this generator to create a new work type in the Knapsack because using the Hyrax work generator will create files in the submodule and we don't want that. ```sh rails generate hyku_knapsack:work WorkType ```
This decorator needs to be in play for the work types to load their respective yaml files.
🎁 Add works generator
🎁 Add SimpleSchemaLoaderDecorator for work types
This commit will fix a bug where the controller template was not being found as well as the model spec. The path was corrected to match the path found in Hyrax. Lastly, the generator now includes adding Hyku specific includes to the controller and model files that were generated.
Update `HykuKnapsack::WorkResourceGenerator`
These files are what we changed in HykuUp Knapsack to get the build, test, and lint workflows working. Also, updating the Hyku submodule to bring in the Valkyrie work.
Attempt to resolve error on pipeline: mv: cannot stat 'rspec.xml': No such file or directory
Ultimately the actions step needs to updated to not run if rspec.xml doesn't exist. We've added specs but there isn't enough to satisfy the pipeline since its processes splits into three test tasks. We'd need at least three separate spec files.
🎁 Contribute back from HykuUp Knapsack
This is a first pass of the PALs work. There was a lot of head scratching and copying things into Hyku Prime. Together this is a rough process.
NoMethodError: undefined method `solr_name' for main:Object (NoMethodError)
=> config.add_index_field solr_name("title", :stored_searchable), label: "Title", itemprop: 'name', if: false
13.69 NoMethodError: undefined method `to_sym' for [:database_authenticatable, {}]:Array (NoMethodError)
13.69
13.69 selected_modules = modules.map(&:to_sym).uniq.sort_by do |s|
13.69 ^^^^
13.69 Did you mean? to_s
13.69 to_set
13.69 /usr/local/bundle/gems/devise-4.9.3/lib/devise/models.rb:82:in `map'
13.69 /usr/local/bundle/gems/devise-4.9.3/lib/devise/models.rb:82:in `devise'
13.69 /app/samvera/hyrax-webapp/app/models/user.rb:16:in `<class:User>'
: no space left on device
This reverts commit d165618.
This commit will: - update Hyku (temporarily on a branch) so WillowSword's initializer doesn't break loading the schema - update SimpleSchemaLoaderDecorator and engine to load earlier - update css locations and imports - update docker-compose.yml to go to pals.test instead of hyku.test
This commit will change the included do to a prended do so the properties are loaded properly.
kirkkwang
approved these changes
May 17, 2024
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched off of Jeremy's original knapsack PR, sha: 6313387
Even though the specs and lint fail, at this point we are able to build and spin up the application. This is before we run any generators to start valkyrizing.
Main's pipeline is already failing, and so is Pals' original repo (so we didn't start with a green pipeline either way).
Issue:
🚧 Add files from PALs Hyku not in other repos
3595d6f
This is a first pass of the PALs work. There was a lot of head
scratching and copying things into Hyku Prime. Together this is a
rough process.
🚧 Partial port of PALs Hyku entries
fac9882
Move functionality to Hyku prime
c0a37d5
Review and override file_set_helper.rb
a274a65
Favor pushing views down into Hyku Prime
0a34b07
Ongoing review of files that were different in 3 or more repositories
1357812
Blank out rendering of Generic Work title
63b6b6b
Adding collections/show as this is unique to PALs
183fdd7
Add custom catalog controller for PALs
de326b4
🎁 Decorate ApplicationController based on PALs criteria
b3e8bda