-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: try to reintroduce Python 3.12, now that NumPy has released a beta. #2644
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
b0a0485
to
c565f8f
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com> style: pre-commit fixes
be1d5fa
to
714f864
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
714f864
to
d6e59d3
Compare
Codecov Report
Additional details and impacted files
|
Currently, the error is due to the
That's a long pip-install command, but I see In the trying to import
line is in that setup.py, too. I don't see any open issues on the |
I don't think this is CMake. When I was digging, it looked like maybe |
Awkward 2.4.0 will not support Python 3.12, but the next one probably will. |
pyarrow-package: "pyarrow==7.0.0" | ||
- python-version: '3.12' | ||
numpy-package: "numpy>=1.26.0b1" | ||
pyarrow-package: "pyarrow;python_version<'3.12'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disable pyarrow for 3.12 without breaking shell
@jpivarski can you give this a once-over? I'm happy to merge now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good and can go ahead before we hear back from @henryiii on Slack about NumPy's thin wheels.
I apparently can't press the "approve" button on my phone, but I approve this.
The two tests that haven't run are the ones with minimal NumPy and minimal pyarrow. The fact that this was merged with main and they're not running could be a sign that they were accidentally dropped in a merger (since you're touching the same files). Could you check on that, to make sure they don't get lost when you merge this into main?
You can approve from a phone as long as you are it the code view part (on web or GitHub's App). |
@jpivarski this PR fuses the two separate NumPy and pyarrow lower-bound tests to run them at the same time. I don't think this is essential, so I'll revert it such that we don't need to change our required tests. |
Here's the first test (on this branch, not deploying to PyPI):
https://github.com/scikit-hep/awkward/actions/runs/5857811221