Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: swap names for __dlpack__ #2741

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix: swap names for __dlpack__ #2741

merged 1 commit into from
Oct 4, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Oct 4, 2023

Somehow, when authoring #2649, I swapped the names for the query descriptor and the dlpack method itself.

@agoose77 agoose77 requested a review from jpivarski October 4, 2023 22:27
jpivarski
jpivarski approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right.

I'll enable auto-merge.

@jpivarski jpivarski enabled auto-merge (squash) October 4, 2023 22:29
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #2741 (5605070) into main (db70407) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
Files Coverage Δ
src/awkward/index.py 89.34% <100.00%> (ø)

@agoose77 agoose77 temporarily deployed to docs-preview October 4, 2023 22:48 — with GitHub Actions Inactive
@jpivarski jpivarski merged commit c377185 into main Oct 4, 2023
36 checks passed
@jpivarski jpivarski deleted the agoose77/fix-dlpack-index branch October 4, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agoose77 @jpivarski