fix: typetracer lengths for optiontypes in 'ak.where' broadcastings #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpivarski
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
This is the right thing to do. The len → length conversion was applied across the whole codebase, but a few instances might have been missed.
In fact, since this is in broadcast_any_option_akwhere, it was missed when adding new code. (This function was added earlier this year.)
Nice tests!
Go ahead and merge!
|
I think this is missing a call to shape_item_as_index, which might need some better docs! I'll take a look tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3321