Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle type tracer correctly in indexed option array flattening #3325

Merged
merged 6 commits into from
Dec 5, 2024

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Dec 4, 2024

Fixes #3324

@pfackeldey if my little patch breaks things please give it a try. I'll try to cook up a test in the mean time.

@lgray lgray changed the title fix: handle type tracer correctly in indexed option array fix: handle type tracer correctly in indexed option array flattening Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.16%. Comparing base (b749e49) to head (781d502).
Report is 212 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
src/awkward/contents/indexedoptionarray.py 88.61% <100.00%> (+0.39%) ⬆️

... and 161 files with indirect coverage changes

@lgray
Copy link
Contributor Author

lgray commented Dec 4, 2024

@jpivarski @pfackeldey this is now ready to go! the fix was that simple.

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jpivarski
Copy link
Member

I think that GitHub Actions is having problems right now.

@lgray
Copy link
Contributor Author

lgray commented Dec 4, 2024

macos-12 images were sunset.

@lgray
Copy link
Contributor Author

lgray commented Dec 4, 2024

or was it supposed to automerge it?

@jpivarski jpivarski merged commit 7191ce8 into scikit-hep:main Dec 5, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flattening of indexed option typetracer array causes comparison of unknown length to known length
2 participants