-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stacktraces for custom exception handling #3343
Conversation
Could you have a look @henryiii on this PR? I remember you had some ideas about it in one of the recent awkward meetings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! (Minor comment below.)
The JAX test failures should be dealt with elsewhere and in one place, perhaps as a single PR that fixes or removes them and then gets merged into all of these pending PRs.
Co-authored-by: Jim Pivarski <jpivarski@users.noreply.github.com>
Great! The jax test fix is in #3340 already :) |
I don't think it's related, but there's a lot of annotations like:
being produced. Edit: Ah, I see Jim mentioned this. Edit: And Peter mentioned a fix. I'm behind. :) |
This PR fixes stack traces for awkward's custom error handling. It allows to use debuggers like "pdb" that try to go through the stack traces again, before they've been evicted from the stack (or wrongly ordered?) (I'm not sure what causes that exactly). This PR does not affect the custom decoration of errors.