build: Move Git submodules to extern directory #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Personally like calling this directory "extern" (boost-histogram and GooFit use this name) |
* Move the https://gitlab.com/fastjet/fastjet.git and https://github.com/cms-externals/fastjet-contrib.git Git submodules into an 'extern' directory to make the directory management cleaner.
matthewfeickert
force-pushed
the
build/use-extern
branch
from
8e3dcb7 to
afa6cd1
Compare
matthewfeickert
changed the title
@henryiii it is now renamed from "external" to "extern". |
|
Merging as should be uncontroversial, but we can easily revert if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the https://gitlab.com/fastjet/fastjet.git and https://github.com/cms-externals/fastjet-contrib.git Git submodules into an 'extern' directory to make the directory management cleaner.
This implements a comment from @henryiii back in #1 (comment).
This does not move the
pybind11submodule given PR #313 removes it.