build: Remove manual CGAL install #315
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewfeickert
requested review from
lgray,
jpivarski,
henryiii and
rkansal47
|
This is ready for review. On my fork I also manually started a wheels build to verify that everything passed across all wheels. (Linux aarch64 jobs take a long time due to emulation — c.f. scikit-hep/boost-histogram#958, which is related but not the main time sink.)
|
matthewfeickert
force-pushed
the
build/remove-cgal-source-download
branch
2 times, most recently
from
438c019 to
8518a1e
Compare
This was referenced Sep 15, 2024
* Remove the manual download of CGAL from setup.py. * Remove '--with-cgaldir' autogen.sh flag as CGAL should be installed in a location by the package managers or user that it is findable.
* The cibuildwheel Linux container is CentOS 7 based, but CGAL is not packaged for CentOS with yum --- only for apt-get, Homebrew, and conda-forge. For Linux cibuildwheel builds this then requires that the CGAL headers (CGLA is header only) need to be manually downloaded from GitHub and then copied into /usr/include/.
* Add libcgal-dev to the required packages to install for Linux based development.
* Use package managers to install libcgal-dev (Linux) and cgal (macOS) in CI jobs.
matthewfeickert
force-pushed
the
build/remove-cgal-source-download
branch
from
8518a1e to
e0c06d1
Compare
matthewfeickert
commented
Sep 16, 2024
…-cgal-header-only' From `./configure --help`: ``` --enable-cgal enables link with the CGAL library default=no --enable-cgal-header-only enable build with header-only install of CGAL, e.g. as for CGALv5; in that case do not use --enable-cgal default=no ```
|
Putting into draft state until PR #319 is merged or closed. |
…--enable-cgal-header-only'" This reverts commit 363f100.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses (and maybe resolves, will need to check) Issue #193.
build: Remove manual CGAL install
--with-cgaldirautogen.shflag as CGAL should be installed in a location by the package managers or user that it is findable.build: Add manual CGAL install for Linux cibuildwheel
yum— only forapt-get, Homebrew, andconda-forge. For Linux cibuildwheel builds this then requires that the CGAL headers (CGAL is header only) need to be manually downloaded from GitHub and then copied into/usr/include/.docs: Add
libcgal-devinstall to READMElibcgal-devto the required packages to install for Linux based development.ci: Add cgal install to CI
libcgal-dev(Linux) andcgal(macOS) in CI jobs.