Moves computation of fLen max to strings.

scikit-hep · Sep 22, 2023 · 3f2fae2 · 3f2fae2
1 parent a0e6d66
commit 3f2fae2
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/uproot/writing/_cascadetree.py b/src/uproot/writing/_cascadetree.py
@@ -1460,12 +1460,9 @@ def write_jagged_basket(self, sink, branch_name, compression, array, offsets):
         )
         compressed_data = uproot.compression.compress(uncompressed_data, compression)
 
-        # get size of biggest string
-        self._metadata["fLen"] = max(
-            [offsets[i + 1] - offsets[i] for i in range(len(offsets) - 1)]
-        )
-
         fLast = offsets[-1]
+        offsets[-1] = 0
+
         fObjlen = len(uncompressed_data)
         fNbytes = fKeylen + len(compressed_data)
 
@@ -1545,6 +1542,11 @@ def write_string_basket(self, sink, branch_name, compression, array, offsets):
         )
         compressed_data = uproot.compression.compress(uncompressed_data, compression)
 
+        # get size of biggest string
+        self._metadata["fLen"] = max(
+            [offsets[i + 1] - offsets[i] for i in range(len(offsets) - 1)]
+        )
+
         fLast = offsets[-1]
         offsets[-1] = 0