feat: support reading of custom-length RNTuple floats and suppressed columns #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It ended up only taking a few lines to support suppressed columns. I'll improve the reading of floats and add some tests. |
ariostas
changed the title
|
This PR is ready for review, but it needs scikit-hep/scikit-hep-testdata#167 for the tests to pass. Also, since there is still an issue with Dask, we'll just have to wait until that is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the reading of
Real32TruncandReal32Quantfields, which have a variable number of bits in the ranges 10-31 and 1-32, respectively.It also adds support for suppressed columns, at least in simple cases.