Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scrapyd-deploy): --list-projects now uses the TARGET positional argument #95

Closed
wants to merge 3 commits into from

Conversation

jpmckinney
Copy link
Contributor

@jpmckinney jpmckinney commented Oct 1, 2021

closes #93

I'm not sure what version level this change belongs to (major/minor/patch). Thoughts?

In light of #96 and #97, maybe better to jump ahead to a 2.0.0 release?

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #95 (e6cd2be) into master (da723bd) will increase coverage by 1.26%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   82.30%   83.56%   +1.26%     
==========================================
  Files           5        5              
  Lines         356      353       -3     
==========================================
+ Hits          293      295       +2     
+ Misses         63       58       -5     
Impacted Files Coverage Δ
scrapyd_client/deploy.py 79.89% <66.66%> (+2.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da723bd...e6cd2be. Read the comment docs.

@jpmckinney jpmckinney removed the request for review from Gallaecio October 1, 2021 21:31
@jpmckinney
Copy link
Contributor Author

On second thought, I think an easier upgrade path is to leave scrapyd-deploy as-is (and deprecate it), and to add addversion as a command on scrapyd-client (without --list-projects and --list-targets options).

@jpmckinney jpmckinney closed this Oct 1, 2021
@jpmckinney jpmckinney deleted the list-projects branch October 1, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-L option accepts target argument, but target is already a positional argument
1 participant