-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More 'mixed' instances to simplify Expression
arithmetic
#479
Conversation
This used to build on #450, but that's now already merged. |
I see there are still some |
Yes, that's exactly right.
Alas, not with the current design. I actually have a prototype PR to enable exactly that. But that's a much larger refactoring, and I still have so many unreviewed clean up PRs left. |
We implement convenient instances to add / multiply / subtract references to expressions.
Nothing changes under the hood, but we move some cloning from the caller to the implementation of arithmetic operations.