Decouple container management #310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayanchoudhary
requested review from
wryonik and
burnerlee
and removed request for
wryonik and
burnerlee
ayanchoudhary
changed the title
ayanchoudhary
changed the title
… layer to decouple with docker client Signed-off-by: Ayan Choudhary <ayanchoudhary1025@gmail.com>
Signed-off-by: Ayan Choudhary <ayanchoudhary1025@gmail.com>
Signed-off-by: Ayan Choudhary <ayanchoudhary1025@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #169
This PR decouples container management logic from the docker client and creates an abstraction layer to allow for generic cr implementation. Currently has docker as the connected cr but will be swapped with containerd+buildkit in later commits
Tasks: