Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nextlove should support .optional() on formData #122

Open
seveibar opened this issue Oct 25, 2023 · 0 comments · May be fixed by #123
Open

Nextlove should support .optional() on formData #122

seveibar opened this issue Oct 25, 2023 · 0 comments · May be fixed by #123

Comments

@seveibar
Copy link
Contributor

seveibar commented Oct 25, 2023 •
edited
Loading

We currently can't do z.object({ ... }).optional() with nextlove's formData, it will always fail to parse, so instead we do a hack where we do z.union([z.any(), z.object({ ... })]), let's fix this!

          yea this is imo a nextlove bug, we should be able to do `.optional()`

Originally posted by @seveibar in https://github.com/seamapi/seam-connect/pull/4685#discussion_r1371085647
@kainpets kainpets linked a pull request Nov 6, 2023 that will close this issue
add test for support for optional formData #123
Draft
@kainpets kainpets removed their assignment Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add test for support for optional formData seamapi/nextlove
2 participants
@seveibar @kainpets