add test for support for optional formData #123
Draft
+683
−1,121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainpets
force-pushed
the
support-zod-optional-formData
branch
from
5a87b62
to
a5eb057
Compare
itelo
reviewed
Nov 13, 2023
| @@ -23,3 +24,28 @@ test("POST /todo/form-add", async (t) => { | |||
|
|
|||
| t.is(successfulRes.status, 200) | |||
| }) | |||
|
|
|||
| test("Valid formData object passes validation", (t) => { | |||
There was a problem hiding this comment.
Would be good to actually call and endpoint
itelo
reviewed
Nov 14, 2023
|
|
||
| axios.defaults.headers.common.Authorization = `Bearer auth_token` | ||
|
|
||
| const bodyFormData = new URLSearchParams() |
There was a problem hiding this comment.
Suggested change
| const bodyFormData = new URLSearchParams() | |
| const bodyFormData = new FormData() |
There was a problem hiding this comment.
Looks like FormData isn't supported. Seve created an issue to implement support for that: #127
seveibar
changed the title
seveibar
reviewed
Dec 7, 2023
|
|
||
| const validFormData = { | ||
| title: "test title", | ||
| clear_sandbox_state: "clear_sandbox_state", |
There was a problem hiding this comment.
Suggested change
| clear_sandbox_state: "clear_sandbox_state", | |
| completed: true, |
seveibar
reviewed
Dec 7, 2023
Comment on lines
49
to
56
| const formDataSchema = z | ||
| .object({ | ||
| title: z.string(), | ||
| clear_sandbox_state: z.literal("clear_sandbox_state"), | ||
| }) | ||
| .safeParse(validFormData) | ||
|
|
||
| t.true(formDataSchema.success) |
There was a problem hiding this comment.
Suggested change
| const formDataSchema = z | |
| .object({ | |
| title: z.string(), | |
| clear_sandbox_state: z.literal("clear_sandbox_state"), | |
| }) | |
| .safeParse(validFormData) | |
| t.true(formDataSchema.success) |
seveibar
reviewed
Dec 7, 2023
seveibar
reviewed
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.