Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to readonly array for array formats #108

Merged
merged 1 commit into from
Aug 11, 2023
Merged

switch to readonly array for array formats #108

merged 1 commit into from
Aug 11, 2023

Conversation

mxsdev
Copy link
Contributor

@mxsdev mxsdev commented Aug 11, 2023

This is causing problems since we often have to call createWithRouteSpec as a const object, which makes the list of array formats readonly, which prevents passing as a normal array.

@mxsdev mxsdev merged commit ca06b79 into main Aug 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codetheweb codetheweb codetheweb approved these changes

@seveibar seveibar Awaiting requested review from seveibar

@itelo itelo Awaiting requested review from itelo itelo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxsdev @codetheweb