jsonResponse should be a Zod schema
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`withRouteSpec()` previously didn't error if `jsonResponse` was a plain JS object.
codetheweb
commented
Jul 6, 2023
| methods: ["POST"], | ||
| auth: "auth_token", | ||
| jsonBody, | ||
| jsonResponse: z.object({ | ||
| ok: z.string(), | ||
| }), | ||
| }) |
There was a problem hiding this comment.
this usage is generally allowed but we weren't testing for it before
seveibar
approved these changes
Jul 6, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
# [2.0.0](v1.4.1...v2.0.0) (2023-07-06) ### Features * Merge pull request [#78](#78) from seamapi/fix-json-response-must-be-zod-schema ([0feab1d](0feab1d)) ### BREAKING CHANGES * existing `jsonResponse` fields may need to be wrapped with `z.object()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withRouteSpec()previously didn't error ifjsonResponsewas a plain JS object.