Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the filtering of query params for path params #93

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Fix the filtering of query params for path params #93

merged 1 commit into from
Jul 21, 2023

Conversation

rchodava
Copy link
Contributor

@rchodava rchodava commented Jul 21, 2023 •
edited
Loading

The omit method only exists on ZodObject and sometimes if we use refine and optional, we will get query params that are ZodEffects or ZodOptional

seveibar
seveibar approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg

@rchodava rchodava merged commit 02aee31 into main Jul 21, 2023
2 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 21, 2023
@semantic-release-bot
chore(release): 2.1.4 [skip ci]
335993f 
## [2.1.4](v2.1.3...v2.1.4) (2023-07-21)

### Bug Fixes

* Merge pull request [#93](#93) from seamapi/fix-query-params-filtering ([02aee31](02aee31))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar approved these changes

@codetheweb codetheweb Awaiting requested review from codetheweb

@itelo itelo Awaiting requested review from itelo itelo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rchodava @seveibar