Configure global exception/error handlers checks #5888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianbergmann
added
type/enhancement
sebastianbergmann
force-pushed
the
main
branch
from
da21665 to
4dddc8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes #5619 configurable and potentially mitigates symfony/symfony#53812 (comment).
On one hand I agree that not releasing error_handlers is probably a mistake, on the other it's cpu intensive to add/remove handlers and is something that you should be able to disable.
Let me know your thought, I'm not sure how this is tested on the phpunit code base and I didn't wanted to do too much in case this is a bad idea, thanks!