-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eslint plugin babel #110
Open
franciscomorais
wants to merge
3
commits into
master
Choose a base branch
from
enhancement/eslint-plugin-babel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add babel plugin and replace no-unused-expressions rule to babel/no-unused-expressions to accept calls with optical chain.
franciscomorais
force-pushed
the
enhancement/eslint-plugin-babel
branch
from
March 27, 2020 17:48
3a180bf
to
f3d165c
Compare
bsonntag
suggested changes
Mar 27, 2020
franciscomorais
force-pushed
the
enhancement/eslint-plugin-babel
branch
from
April 27, 2020 11:02
f3d165c
to
5449fec
Compare
bsonntag
suggested changes
Apr 28, 2020
franciscomorais
force-pushed
the
enhancement/eslint-plugin-babel
branch
from
May 4, 2020 09:53
5449fec
to
e05db8b
Compare
bsonntag
approved these changes
Jun 4, 2020
@joaonice ping. |
bsonntag
suggested changes
Sep 1, 2021
@@ -43,6 +43,7 @@ | |||
}, | |||
"dependencies": { | |||
"babel-eslint": "10.0.1", | |||
"eslint-plugin-babel": "^5.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint-plugin-babel
was renamed to @babel/eslint-plugin
, please update this to use that one instead.
I'll take over this. |
Hm, turns out we need to upgrade to Eslint v7 first to be able to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
eslint-plugin-babel
plugin to replace theno-unused-expressions
rule tobabel/no-unused-expressions
. This rule doesn't work well with optical chaining, like this: