Skip to content
This repository has been archived by the owner on Sep 24, 2024. It is now read-only.

fix: component transitions #152

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix: component transitions #152

merged 1 commit into from
Sep 25, 2023

Conversation

cuiyajie
Copy link
Contributor

I find transitions not working in some components. It failed caused by the original code mix Transition from 'vue' with TransitionChild from '@headlessui/vue'. In Modal component, the binding attribute :bind not working, that should be v-bind. So I create this PR.

selemondev
selemondev approved these changes Sep 25, 2023
View reviewed changes
Copy link
Owner

@selemondev selemondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cuiyajie 😄

@selemondev selemondev merged commit 6b6547e into selemondev:main Sep 25, 2023
1 check failed
selemondev added a commit that referenced this pull request Sep 25, 2023
@selemondev
fix(app): #152 component transitions
7141ea9 
Closes: #152
@selemondev selemondev mentioned this pull request Sep 25, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@selemondev selemondev selemondev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cuiyajie @selemondev