Config Updates and Fixes + More Documentation #20
+415
−247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w for creation of config file and support setting up with no host name in the config file
| @@ -26,7 +28,7 @@ const LOCAL_SERVER_HOST: &str = "127.0.0.1:8000"; | |||
|
|
|||
| #[derive(Serialize, Deserialize, Debug, Clone)] | |||
| pub struct HaConfig { | |||
| pub host: String, | |||
| pub host: Option<String>, | |||
There was a problem hiding this comment.
Not sure i get why this is optional?
There was a problem hiding this comment.
So I made adding the host a part of the setup process. So technically when we first go to parse the config file, the way we can tell if we need to add run the add the host logic is by checking if this is None or Some.
I agree its a bit weird because it for sure isn't optional for the app to run but not sure of another good mechanism to let us know the user hasn't setup a host yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding more documentation on how to get started (with what little we have)
Also adding the ability to setup with no config file or setup with no host. The setup process will not create a config if it doesn't exist and ask the user to enter a ha host if it does not exist in the config.