fix: null pointer to logger

semaphoreui · Feb 4, 2024 · 78c93b1 · 78c93b1
1 parent 94c5dcb
commit 78c93b1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/db_lib/AppFactory.go b/db_lib/AppFactory.go
@@ -2,14 +2,16 @@ package db_lib
 
 import (
 	"github.com/ansible-semaphore/semaphore/db"
+	"github.com/ansible-semaphore/semaphore/lib"
 )
 
-func CreateApp(template db.Template, repository db.Repository) LocalApp {
+func CreateApp(template db.Template, repository db.Repository, logger lib.Logger) LocalApp {
 	switch template.App {
 	case db.TemplateAnsible:
 		return &AnsibleApp{
 			Template:   template,
 			Repository: repository,
+			Logger:     logger,
 			Playbook: &AnsiblePlaybook{
 				TemplateID: template.ID,
 				Repository: repository,

diff --git a/services/runners/JobPool.go b/services/runners/JobPool.go
@@ -498,7 +498,7 @@ func (p *JobPool) checkNewJobs() {
 				Inventory:   newJob.Inventory,
 				Repository:  newJob.Repository,
 				Environment: newJob.Environment,
-				App:         db_lib.CreateApp(newJob.Template, newJob.Repository),
+				App:         db_lib.CreateApp(newJob.Template, newJob.Repository, nil),
 			},
 		}
 

diff --git a/services/tasks/TaskPool.go b/services/tasks/TaskPool.go
@@ -361,7 +361,7 @@ func (p *TaskPool) AddTask(taskObj db.Task, userID *int, projectID int) (newTask
 			Repository:  taskRunner.Repository,
 			Environment: taskRunner.Environment,
 			Logger:      &taskRunner,
-			App:         db_lib.CreateApp(taskRunner.Template, taskRunner.Repository),
+			App:         db_lib.CreateApp(taskRunner.Template, taskRunner.Repository, &taskRunner),
 		}
 	}