Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing To header in email alert causes email being caught by antispam #1603

Closed
xnilsit opened this issue Nov 1, 2023 · 1 comment
Closed

Comments

@xnilsit
Copy link

xnilsit commented Nov 1, 2023

When testing email notifications I noticed, that my spam filter complained about the missing To header.

After investigating I noticed, that th To header was indeed not implemented.

https://github.com/ansible-semaphore/semaphore/blob/85d9936082bc8a3fc763ff8d3f1f6a6695bfc956/services/tasks/alert.go#L13-L17

I fixed it in my fork and will create a pull request, so it can be merged if you approve of the changes.

@tboerger
Copy link
Collaborator

tboerger commented Mar 4, 2024

My PR #1788 have been merged which fixes this issue.

@tboerger tboerger closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants