FIX: add To mail header #1636
Closed
FIX: add To mail header #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have used a different approach within #1788 |
|
The PR #1788 have been merged, so this change is obsolete. Thanks for taking care of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1603, this fixes the missing To header in email alerts that may cause spamfilters to block the email.
To was added to emailTemplate and Alert struct.
Some stuff needed to be moved within the for loop:
mailBuffer is reset in each loop iteration, so that the mail content is not duplicated.
alert.To is reassigned to the email address of the user and the template is re-executed with the new values.