-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix base URI not included in generated OpenID Connect URLs (#1524) #1572
base: develop
Are you sure you want to change the base?
Conversation
HI @fiftin it would be great if you can review this, it is a relatively simple change but OIDC + sub-path on the URL does not work without it. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is the WebHost options this makes sense.
Since these changes have been approved, could this PR be merged, soon? Currently, using OpenID-Connect with |
Any movement on this PR? I'd like to call out the documentation suggests doing this for those who run reverse proxies. https://docs.semui.co/administration-guide/configuration#public-url After two days of OIDC troubleshooting, coming across this was a relief. |
Huh, is anybody here? |
I have rebased this against the current develop, @fiftin perhaps you have a chance to have a look? |
Did you test it? |
Yes I am running it for nearly a year now with web_host set to https://xyz.com/semaphore . |
Thank you! Merging. |
Hey @fiftin thanks but I don't see the commits on develop ? |
OpenID Connect login does not work when the base URI includes a path component. This PR fixes this.