Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix base URI not included in generated OpenID Connect URLs (#1524) #1572

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hmoffatt
Copy link

@hmoffatt hmoffatt commented Oct 15, 2023

OpenID Connect login does not work when the base URI includes a path component. This PR fixes this.

@hmoffatt
Copy link
Author

hmoffatt commented Feb 5, 2024

HI @fiftin it would be great if you can review this, it is a relatively simple change but OIDC + sub-path on the URL does not work without it. Thanks.

Copy link
Collaborator

@tboerger tboerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is the WebHost options this makes sense.

@ChristianCiach
Copy link

Since these changes have been approved, could this PR be merged, soon? Currently, using OpenID-Connect with SEMAPHORE_WEB_ROOT is broken.

@stuntguy3000
Copy link

Any movement on this PR? I'd like to call out the documentation suggests doing this for those who run reverse proxies.

https://docs.semui.co/administration-guide/configuration#public-url

After two days of OIDC troubleshooting, coming across this was a relief.

@veshus
Copy link

veshus commented Jul 17, 2024

Huh, is anybody here?

@hmoffatt
Copy link
Author

I have rebased this against the current develop, @fiftin perhaps you have a chance to have a look?
I have my Semaphore hosted at https://domain.com/semaphore and it is working for me with this change.

@fiftin
Copy link
Collaborator

fiftin commented Aug 20, 2024

Hi @hmoffatt , @tboerger sorry, I missed this PR.

@fiftin
Copy link
Collaborator

fiftin commented Aug 20, 2024

Did you test it?

@hmoffatt
Copy link
Author

Did you test it?

Yes I am running it for nearly a year now with web_host set to https://xyz.com/semaphore .

@fiftin
Copy link
Collaborator

fiftin commented Oct 19, 2024

Thank you! Merging.

@hmoffatt
Copy link
Author

Hey @fiftin thanks but I don't see the commits on develop ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants