-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLNP-5218] feat: RTL support #203
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
- Coverage 11.57% 11.54% -0.03%
==========================================
Files 356 357 +1
Lines 8389 8454 +65
Branches 2343 2240 -103
==========================================
+ Hits 971 976 +5
- Misses 7343 7477 +134
+ Partials 75 1 -74 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@@ -42,6 +42,15 @@ const ProgressBar = ({ current = 100, total = 100, trackColor, barColor, overlay | |||
return NOOP; | |||
}, [percent]); | |||
|
|||
const progressBarPosition = (() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The progress bar that displays time should always be positioned on the left.
Therefore, when doLeftAndRightSwapInRTL
is true, specifying right: 0
will position it on the left.
af7b421
to
140f4c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
…roupChannelHandler
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can setup a CLA to allow for the contribution.
For Internal Contributors
CLNP-5218
Description Of Changes
Support RTL
docs: https://sendbird.atlassian.net/wiki/spaces/SDK/pages/2580578356/RTL+Support+in+React-Native+UIKit
Types Of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that apply_