Replace serenity::json::prelude with public wrapper functions
#2569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
model
|
I have no idea why the doctest on |
|
Taking Cow and documenting the clone for simd_json would be the best path. |
arqunis
approved these changes
Oct 20, 2023
arqunis
added
enhancement
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 24, 2023
…nity-rs#2569) To avoid future breakage, we shouldn't re-export functions from dependency libraries in case a function signature changes, which would pass on breaking changes to Serenity's users. Providing wrapper functions solves this issue. Note: changed `from_str` to take `&str` instead of `String`, and simply clone it for the `simd_json` case. This means the more common `serde_json` use case no longer requires ownership (or an extra clone before passing the string in).
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
…nity-rs#2569) To avoid future breakage, we shouldn't re-export functions from dependency libraries in case a function signature changes, which would pass on breaking changes to Serenity's users. Providing wrapper functions solves this issue. Note: changed `from_str` to take `&str` instead of `String`, and simply clone it for the `simd_json` case. This means the more common `serde_json` use case no longer requires ownership (or an extra clone before passing the string in).
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
…nity-rs#2569) To avoid future breakage, we shouldn't re-export functions from dependency libraries in case a function signature changes, which would pass on breaking changes to Serenity's users. Providing wrapper functions solves this issue. Note: changed `from_str` to take `&str` instead of `String`, and simply clone it for the `simd_json` case. This means the more common `serde_json` use case no longer requires ownership (or an extra clone before passing the string in).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid future breakage, we shouldn't re-export functions from dependency libs in case a function signature changes, which would pass on breaking changes to serenity's users. Providing wrapper functions solves this issue.
Note: changed
from_strto take&strinstead ofString, and simply clone it for thesimd_jsoncase. This means the more commonserde_jsonuse case no longer requires ownership (or an extra clone before passing the string in).