Update gateway intents with up-to-date information

[cheesycod]

Updates the gateway intents with up to date information. Also removes GUILD_BANS as it doesn't even exist anymore

[mkrasnitski]

Do you think it might be better to simply deprecate GUILD_BANS, since it's basically just been renamed?

[cheesycod]

Do you think it might be better to simply deprecate GUILD_BANS, since it's basically just been renamed?

It was deprecated until now (that was what I earlier did). But, tbh I think it should be removed now so it can be one breaking release instead of doing it later in my opinion.

[mkrasnitski]

I'm talking about specifically marking the constant as #[deprecated], which isn't currently the case. I think that since it's just a name, it's not a big deal to mark it as deprecated and wait a release cycle to remove it, to give people time to change. Serenity already has some things which will are marked deprecated in 0.12 and will be removed in 0.13.

But, if you think most people won't notice, then breaking it immediately might be fine too.

[cheesycod]

I'm talking about specifically marking the constant as #[deprecated], which isn't currently the case. I think that since it's just a name, it's not a big deal to mark it as deprecated and wait a release cycle to remove it, to give people time to change. Serenity already has some things which will are marked deprecated in 0.12 and will be removed in 0.13.

But, if you think most people won't notice, then breaking it immediately might be fine too.

True, I'm conflicted by that too. I do think that its a really simple change to make anyways and that most people won't really notice. I bet most just enable all non-priv intents anyways

[mkrasnitski]

After some thought, I think the best course of action is to just keep the old name and mark it with #[deprecated = "use `GatewayIntents::GUILD_MODERATION` instead"].

[cheesycod]

Alright, will do in a bit

[mkrasnitski]

Also, turns out MANAGE_EMOJIS_AND_STICKERS has also been renamed to MANAGE_GUILD_EXPRESSIONS (See docs.) Would be good to rename and deprecate the old name for this permission as well.

EDIT: I was confusing permissions and gateway intents. Ignore what I said; this change should be made separately since there are other related permissions changes it could go with.

[cheesycod]

gateway intents. Ignore what I said; this change should be made separately since there are other related permissions changes

Alright

[mkrasnitski]

Just to be clear, I still think GUILD_BANS should be deprecated with this PR. Sorry for the confusion.

[tazz4843]

Can be closed in favor of #2593