Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add experimental typesize support #2592

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Add experimental typesize support #2592

merged 2 commits into from
Nov 24, 2023

Conversation

GnomedDev
Copy link
Member

Adds a simple integration with my new typesize library to help users find which caches are using up the most ram. This is highly experimental, hence the lack of documentation, but could be seriously useful.

@github-actions github-actions bot added model Related to the `model` module. cache Related to the `cache`-feature. labels Nov 16, 2023
tazz4843
tazz4843 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@tazz4843 tazz4843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, besides the lack of docs but as you said experimental crate. Seems like a super useful feature esp with the cache metrics.

@GnomedDev GnomedDev force-pushed the typesize branch 2 times, most recently from e57d2ed to 85fcddf Compare November 17, 2023 11:11
@GnomedDev GnomedDev mentioned this pull request Nov 17, 2023
Merged
tazz4843
tazz4843 reviewed Nov 17, 2023
View reviewed changes
src/cache/mod.rs Outdated Show resolved Hide resolved
@GnomedDev GnomedDev changed the base branch from next to current November 19, 2023 21:42
@GnomedDev GnomedDev force-pushed the typesize branch 2 times, most recently from 01f16c1 to 45e8aa2 Compare November 21, 2023 14:49
@GnomedDev
Copy link
Member Author

Just pushed an update to get rid of the manual get_statistics method. That is now automatically derived by the macro for all the structs annotated.

@arqunis arqunis added enhancement An improvement to Serenity. dependencies Related to Serenity dependencies. labels Nov 24, 2023
@arqunis arqunis merged commit 66dde5d into serenity-rs:current Nov 24, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tazz4843 tazz4843 tazz4843 approved these changes

@mkrasnitski mkrasnitski mkrasnitski left review comments

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
cache Related to the `cache`-feature. dependencies Related to Serenity dependencies. enhancement An improvement to Serenity. model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GnomedDev @arqunis @mkrasnitski @tazz4843