Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify shared crate metadata at the workspace level #3077

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

mkrasnitski
Copy link
Collaborator

This keeps crate metadata in sync across the whole workspace, including MSRV and edition, plus adds some missing metadata fields to serenity's subcrates.

Feedback wanted: should the authors field also be applied to the whole workspace? Note that workspace fields are opt-in via field.workspace = true and can be overridden by simply providing a field = ... value.

@github-actions github-actions bot added voice Related to the `voice` module and `serenity_voice_model` crate. command_attr Related to the `command_attr` crate. labels Dec 8, 2024
@mkrasnitski mkrasnitski mentioned this pull request Dec 8, 2024
@arqunis arqunis added the enhancement An improvement to Serenity. label Dec 8, 2024
@arqunis
Copy link
Member

arqunis commented Dec 8, 2024

Feedback wanted: should the authors field also be applied to the whole workspace? Note that workspace fields are opt-in via field.workspace = true and can be overridden by simply providing a field = ... value.

I believe that should be set individually per crate, especially since we want to integrate poise into the Serenity repository, which has a different authors field.

@arqunis arqunis merged commit 2274b32 into serenity-rs:current Dec 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command_attr Related to the `command_attr` crate. enhancement An improvement to Serenity. voice Related to the `voice` module and `serenity_voice_model` crate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants