Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy support for got via global-agent #194

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

croensch
Copy link

@croensch croensch commented Mar 4, 2023

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@croensch thanks for addressing that. Ideally if this has minimal impact for all of us which do not rely on any proxy setup

download.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (5e2f1bf) 89.08% compared to head (650e119) 89.11%.

❗ Current head 650e119 differs from pull request most recent head d0f51ab. Consider uploading reports for the commit d0f51ab to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   89.08%   89.11%   +0.02%     
==========================================
  Files          27       27              
  Lines         742      744       +2     
==========================================
+ Hits          661      663       +2     
  Misses         81       81              
Impacted Files Coverage Δ
download.js 84.48% <100.00%> (+0.55%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

download.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants