Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dump (with clean flag) and import method for psql #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dfang
Copy link

@dfang dfang commented Apr 24, 2014

for postgres database, i changed dump with clean flag then import.

normally, we use cap staging db:pull or db:push to sync databases between local and staging for testing, i think this is enough, we don't need to terminate the conection(there is a syntax problem about this, see this issue #28), dropdb, createdb then import

what do you think ?

@sgruhier
Copy link
Owner

I'm not a postgres user.
I'm ok to merge that PR, anyone to confirm we can remove the terminate command? Or may add it as an option?

@rafaelsales
Copy link
Contributor

@sgruhier I've been doing manually the process this gem does and I never terminate server process on a database. In many projects I worked on, it's common that developers copy production database to their local machines.

I don't think disturbing the production users is a good idea. Moreover, I never faced issues with production dumps even when the site is in reasonable traffic.

I'm confident this is good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants